Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #7

Merged
merged 9 commits into from
Nov 2, 2023
Merged

Clean code #7

merged 9 commits into from
Nov 2, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #7 (6478b98) into main (09c1b23) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     94.32%   94.21%   -0.11%     
  Complexity       97       97              
============================================
  Files            28       28              
  Lines           652      640      -12     
============================================
- Hits            615      603      -12     
  Misses           37       37              
Files Coverage Δ
src/Model/Identity.php 100.00% <100.00%> (ø)
src/UseCase/Controller.php 55.55% <100.00%> (ø)
src/UseCase/Login/view/index.php 89.47% <100.00%> (ø)
src/UseCase/Register/RegisterForm.php 100.00% <100.00%> (ø)
src/UseCase/Register/RegisterService.php 100.00% <100.00%> (ø)
src/UseCase/Register/view/index.php 100.00% <100.00%> (ø)

@terabytesoftw terabytesoftw merged commit 529c93e into main Nov 2, 2023
11 of 12 checks passed
@terabytesoftw terabytesoftw deleted the clean-code branch November 2, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants